Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP] shopfloor cluster picking: Add option to sort processed move lines #964

Open
wants to merge 2 commits into
base: 14.0
Choose a base branch
from
Open

[14.0][IMP] shopfloor cluster picking: Add option to sort processed move lines #964

wants to merge 2 commits into from
+279 −11

Conversation

grindtildeath
Copy link
Contributor

@grindtildeath grindtildeath commented Dec 30, 2024 •
edited by jbaudoux
Loading

Have an option “Sort method for processing move lines”

Have implementations:

  • by priority & location
    • this is the current implementation and should be the default
    • each line is sorted by priority and then by location to perform a smart path in the warehouse
  • by location grouped by product
    • in case of multiple move lines for the same product, break the sorting to finalize a started product by processing all other move lines for that product in order to group a product on a picking device. When stacking products on a pallet, this prevents to spread a same product at different level on the stack.
  • by custom

@OCA-git-bot
Copy link
Contributor

Hi @sebalix, @guewen, @simahawk,
some modules you are maintaining are being modified, check this out!

sebalix
sebalix reviewed Jan 3, 2025
View reviewed changes
Copy link
Contributor

@sebalix sebalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, that would be nice to add tests

@jbaudoux jbaudoux changed the title shopfloor: Add option to sort move lines on processing of cluster pic… [14.0][IMP] shopfloor cluster picking: Add option to sort processed move lines Jan 6, 2025
jbaudoux
jbaudoux reviewed Jan 6, 2025
View reviewed changes
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. Both sortings are by location, selections are misleading. Here is a proposal a new naming.

Include the existing test for the second sorting option

shopfloor/models/shopfloor_menu.py Outdated Show resolved Hide resolved
shopfloor/models/shopfloor_menu.py Show resolved Hide resolved
shopfloor/services/cluster_picking.py Outdated Show resolved Hide resolved
shopfloor/services/cluster_picking.py Outdated Show resolved Hide resolved
@rousseldenis
Copy link
Contributor

rousseldenis commented Jan 7, 2025 •
edited
Loading

FYI, there is something related : #917

@grindtildeath @sebalix @jbaudoux

@grindtildeath grindtildeath force-pushed the 14.0-shopfloor-cluster_picking_sort_lines branch from ad5798a to 55fa1e3 Compare January 7, 2025 15:46
@jbaudoux
Copy link
Contributor

jbaudoux commented Jan 7, 2025

FYI, there is something related : #917

@grindtildeath @sebalix @jbaudoux

@rousseldenis Yes it is in the same spirit than that solution. The one you mention is for the get work to choose the right pickings. This one is for after when you process the picking to define in which order you process the lines

@grindtildeath
Copy link
Contributor Author

@sebalix tests added
@jbaudoux I did the requested changes.
@rousseldenis actually this was inspired by the PR you mentioned 😉

jbaudoux
jbaudoux reviewed Jan 10, 2025
View reviewed changes
shopfloor/tests/test_cluster_picking_sort_order.py
Comment on lines +25 to +28
cls.menu.sudo().move_line_processing_sort_order = "location_grouped_product"
return

def test_custom_lines_order(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cls.menu.sudo().move_line_processing_sort_order = "location_grouped_product"
return
def test_custom_lines_order(self):
def test_location_grouped_product_sorting(self):
self.menu.sudo().move_line_processing_sort_order = "location_grouped_product"

TDu
TDu approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@TDu TDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbaudoux jbaudoux jbaudoux left review comments

@sebalix sebalix sebalix left review comments

@TDu TDu TDu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@grindtildeath @OCA-git-bot @rousseldenis @jbaudoux @TDu @sebalix